Attention is currently required from: falconia, dexter.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32685 )
Change subject: codec: replace GSM-FR ECU with new implementation ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2: I think review of this patch is slightly more difficult than it should be due to mixing a file rename with introducing new code. Maybe first have a commit doing the rename (purely cosmetic, non-functional) and then a commit that adds the new implementation?
Also, I'm not sure if we actually still need to support the direct API that doesn't go through osmo_ecu_ops_fr. osmo-bts >= 1.2.0 already uses the the ecu_ops architecture. But unfortunately 0.8.0 - 1.1.0 use the old API, so it was in use longer than I thought :/
-
laforge