Attention is currently required from: laforge, pespin.

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39848?usp=email )

Change subject: library/s1ap: split PDU specific API to S1AP_Utils.ttcn ......................................................................

Patch Set 1:

(1 comment)

File library/S1AP_Utils.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39848/comment/bb2fbb47_c5fbc... : PS1, Line 1: module S1AP_Utils {

Acknowledged

I am all for using consistent naming, and I am happy to amend this patch. But before doing so, let's see what kinds of naming we already have in the `library`:

``` $ ls library/ | grep -i -e helper -e function -e utils BSSGP_Helper.cc BSSGP_Helper_Functions.ttcn DNS_Helpers.ttcn Misc_Helpers.ttcn Native_FunctionDefs.cc Native_Functions.ttcn Osmocom_CTRL_Functions.ttcn Osmocom_VTY_Functions.ttcn USSD_Helpers.ttcn

```

so we have:

* `Helper` / `Helpers`, * `Functions` (as you suggest), * `Helper_Functions`.

There's no `Utils`, so I need to pick something else to avoid adding even more variants. I find `S1AP_Helper_Functions` quite long and verbose, so I would go for `Functions` or `Helpers`.