Attention is currently required from: fixeria, dexter.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/pysim/+/28725
)
Change subject: Introduce APDU/TPDU trace decoder
......................................................................
Patch Set 5:
(1 comment)
File pySim/apdu/__init__.py:
https://gerrit.osmocom.org/c/pysim/+/28725/comment/3db18ae0_2eabaeb7
PS5, Line 70: cmd
rsp?
nice catch. Didn't show up as you
usually have either str for both cmd/rsp or bytes.
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/28725
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I862d93163d495a294364168f7818641e47b18c0a
Gerrit-Change-Number: 28725
Gerrit-PatchSet: 5
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 23 Jul 2022 10:20:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment