Attention is currently required from: neels.
jolly has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-abis/+/31296 )
Change subject: Reworked mi_e1_line_update() and some of its sub routines
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/libosmo-abis/+/31296/comment/0c9cd049_83d87ccf
PS3, Line 7: Reworked mi_e1_line_update() and some of its sub routines
(btw, it is a good practice to write commit logs in
"imperative form", shortest and most clear. […]
Ack
Patchset:
PS3:
If I understand it correctly, I would say "make mi_e1_line_update() and their sub
routines work correctly"
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-abis/+/31296
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Iab0776fce6921661b39e9e53376cf01a80bcd42c
Gerrit-Change-Number: 31296
Gerrit-PatchSet: 3
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 16 Feb 2023 17:04:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: comment