[M] Change in osmo-ttcn3-hacks[master]: s1gw: derive functions from f_TC_e_rab_setup() - gerrit-log

12 Sep 2024


      Attention is currently required from: fixeria, laforge.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38062?usp=email )
Change subject: s1gw: derive functions from f_TC_e_rab_setup()
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File s1gw/S1GW_ConnHdlr.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38062/comment/4d9b4da0_65076... :
PS2, Line 328: 	for (var integer i := 0; i < lengthof(erabs); i := i + 1) {
You could actually split this for loop in a function which returns E_RABToBeSetupListBearerSUReq. Same for other functions.
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38062?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I1bff371da6337ecd7710219d1c86f0fff82ad17f
Gerrit-Change-Number: 38062
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Thu, 12 Sep 2024 12:43:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes