Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29614 )

Change subject: Add Osmux IPv6 support ......................................................................

Patch Set 2:

(5 comments)

File src/libosmo-mgcp/mgcp_network.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/29614/comment/3ce99678_480fe64f PS2, Line 102: if (mgcp_conn_rtp_is_osmux(conn)) { Having a scoped const pointer:

const struct mgcp_config *cfg = conn->conn->endp->trunk->cfg;

would improve readability of this function.

File src/libosmo-mgcp/mgcp_osmux.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/29614/comment/044b50bd_e3407121 PS2, Line 459: cfg->osmux_addr_v4, cfg->osmux_port); broken alignment

https://gerrit.osmocom.org/c/osmo-mgw/+/29614/comment/fd4e87ff_7e22dcf9 PS2, Line 466: osmo_sock_get_name2(osmux_fd_v4.fd)); broken alignment

https://gerrit.osmocom.org/c/osmo-mgw/+/29614/comment/95438cb0_c39f945f PS2, Line 477: cfg->osmux_addr_v6, cfg->osmux_port); broken alignment

https://gerrit.osmocom.org/c/osmo-mgw/+/29614/comment/c49269a8_7d2b4447 PS2, Line 484: osmo_sock_get_name2(osmux_fd_v6.fd)); broken alignment