Attention is currently required from: pespin.

View Change

5 comments:

• File src/libosmo-mgcp/mgcp_network.c:

  • Patch Set #2, Line 102: if (mgcp_conn_rtp_is_osmux(conn)) {

    Having a scoped const pointer:

      const struct mgcp_config *cfg = conn->conn->endp->trunk->cfg;

    would improve readability of this function.

• File src/libosmo-mgcp/mgcp_osmux.c:

  • Patch Set #2, Line 459: cfg->osmux_addr_v4, cfg->osmux_port);

    broken alignment

  • Patch Set #2, Line 466: osmo_sock_get_name2(osmux_fd_v4.fd));

    broken alignment

  • Patch Set #2, Line 477: cfg->osmux_addr_v6, cfg->osmux_port);

    broken alignment

  • Patch Set #2, Line 484: osmo_sock_get_name2(osmux_fd_v6.fd));

    broken alignment

To view, visit change 29614. To unsubscribe, or for help writing mail filters, visit settings.