[L] Change in osmocom-bb[master]: ASCI: Add decoding of SYSTEM INFORMATION TYPE 10 $(ASCI)$ - gerrit-log

4 Oct 2023

Attention is currently required from: fixeria, pespin.

jolly has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/34614?usp=email )

Change subject: ASCI: Add decoding of SYSTEM INFORMATION TYPE 10 $(ASCI)$
......................................................................

Patch Set 2:

(9 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmocom-bb/+/34614/comment/b91d95a1_9aa56e1d 
PS1, Line 7: ASCI: Add decoding of SYSTEM INFORMATION TYPE 10 $(ASCI)$
...
  what's this $(ASCI)$ here at the end? This
is the full name of the message. See 9.1.50 in TS 44.018

File src/host/layer23/include/osmocom/bb/common/sysinfo.h:

https://gerrit.osmocom.org/c/osmocom-bb/+/34614/comment/0da1c9c2_badec80b 
PS1, Line 179: 	uint8_t				si10_cells; /* number neighbor cells found in SI 10 */
...
  having si10_cells vs si10_cell below is highly
misleading and prone to error. […] Done

File src/host/layer23/src/common/sysinfo.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/34614/comment/763773c1_947c4915 
PS1, Line 613: Band indicator
...
  `BA_IND` is actually BCCH allocation sequence number
indication, and not a band indicator? The loggi […] Done

https://gerrit.osmocom.org/c/osmocom-bb/+/34614/comment/8ba02555_3007e56d 
PS1, Line 632: parameter
...
  parameter(s) Done

https://gerrit.osmocom.org/c/osmocom-bb/+/34614/comment/d6f90d90_1b0eb210 
PS1, Line 651: bitvec_get_uint(bv, 6) - 110
...
  use `rxlev2dbm()` Done

https://gerrit.osmocom.org/c/osmocom-bb/+/34614/comment/5698da68_d3410d58 
PS1, Line 1040: static int16_t arfcn_from_freq(struct gsm48_sysinfo *s, uint16_t index)
...
  according to the param looks mmore like
arfcn_from_index ;) […] The specs calls it "frequency", but it is actually
an index, relative to SI5(bis/ter). I will rename it to arfcn_from_freq_index

https://gerrit.osmocom.org/c/osmocom-bb/+/34614/comment/e341b873_6dd49678 
PS1, Line 1091: puts
...
  debugging leftovers? Done

File src/host/layer23/src/mobile/gsm48_rr.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/34614/comment/62e9932a_17189645 
PS1, Line 2900: /* receive "SYSTEM INFORMATION 10" message (9.1.50) */
...
  why turning the first char into a lowcase her?
Done

https://gerrit.osmocom.org/c/osmocom-bb/+/34614/comment/95655a3b_5b9513d1 
PS1, Line 2909: 		LOGP(DRR, LOGL_INFO, "No cell selected, SYSTEM INFORMATION 10
"
...
  all these can git in one line. Done

-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34614?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I81c7929f6d951d8eef7d08624f0b72830370c448
Gerrit-Change-Number: 34614
Gerrit-PatchSet: 2
Gerrit-Owner: jolly &lt;andreas(a)eversberg.eu&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-CC: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Comment-Date: Wed, 04 Oct 2023 10:47:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt;
Comment-In-Reply-To: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-MessageType: comment