Attention is currently required from: fixeria, pespin.
9 comments:
Commit Message:
Patch Set #1, Line 7: ASCI: Add decoding of SYSTEM INFORMATION TYPE 10 $(ASCI)$
what's this $(ASCI)$ here at the end?
This is the full name of the message. See 9.1.50 in TS 44.018
File src/host/layer23/include/osmocom/bb/common/sysinfo.h:
Patch Set #1, Line 179: uint8_t si10_cells; /* number neighbor cells found in SI 10 */
having si10_cells vs si10_cell below is highly misleading and prone to error. […]
Done
File src/host/layer23/src/common/sysinfo.c:
Patch Set #1, Line 613: Band indicator
`BA_IND` is actually BCCH allocation sequence number indication, and not a band indicator? The loggi […]
Done
Patch Set #1, Line 632: parameter
parameter(s)
Done
Patch Set #1, Line 651: bitvec_get_uint(bv, 6) - 110
use `rxlev2dbm()`
Done
Patch Set #1, Line 1040: static int16_t arfcn_from_freq(struct gsm48_sysinfo *s, uint16_t index)
according to the param looks mmore like arfcn_from_index ;) […]
The specs calls it "frequency", but it is actually an index, relative to SI5(bis/ter). I will rename it to arfcn_from_freq_index
debugging leftovers?
Done
File src/host/layer23/src/mobile/gsm48_rr.c:
Patch Set #1, Line 2900: /* receive "SYSTEM INFORMATION 10" message (9.1.50) */
why turning the first char into a lowcase her?
Done
Patch Set #1, Line 2909: LOGP(DRR, LOGL_INFO, "No cell selected, SYSTEM INFORMATION 10 "
all these can git in one line.
Done
To view, visit change 34614. To unsubscribe, or for help writing mail filters, visit settings.