Attention is currently required from: fixeria, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39158?usp=email ) Change subject: pcap-server: Make rotate-localtime feature configurable through VTY ...................................................................... Patch Set 3: (5 comments) File configure.ac: https://gerrit.osmocom.org/c/osmo-pcap/+/39158/comment/2fcc87ea_b9b4ffa1?us… : PS3, Line 65: dnl patching ${archive_cmds} to affect generation of file "libtool" to fix linking with clang put the configure.ac and .gitignore changes into an extra commit? File doc/manuals/chapters/server.adoc: https://gerrit.osmocom.org/c/osmo-pcap/+/39158/comment/2590661c_f1a8c82c?us… : PS3, Line 117: Maybe worth document what happens if the system's localtime goes backward (daylight savings time or drifting and getting adjusted?) Actually I'm wondering if that could lead to overwriting previous files, if going backwards 1h because of DST and you have e.g. "rotate-localtime minute". That could happen if the timestamp is part of the filename instead of an ever increasing number (not sure if that is the case, maybe also worth documenting here if it isn't in the docs yet). File src/osmo_server_network.c: https://gerrit.osmocom.org/c/osmo-pcap/+/39158/comment/082cef03_26f31753?us… : PS3, Line 231: /* Checks if we are in a new record period since last time we wrote to a pcap, to know (return true) whether a new pcap file needs to be opened. cosmetic: very long line File src/osmo_server_vty.c: https://gerrit.osmocom.org/c/osmo-pcap/+/39158/comment/f903f301_613af12d?us… : PS3, Line 219: frecuency frequency https://gerrit.osmocom.org/c/osmo-pcap/+/39158/comment/f5948c45_38536a53?us… : PS3, Line 246: max_mod = 4294967295; (that will take a while :D) is there some constant we could use instead of this magic number? Same in DEFUN(cfg_server_rotate_localtime_mod_n. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39158?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Idf17a161c17050bb62793a82e39179a093b35f73 Gerrit-Change-Number: 39158 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 18 Dec 2024 10:41:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No