Attention is currently required from: fixeria, laforge, pespin.
5 comments:
File configure.ac:
Patch Set #3, Line 65: dnl patching ${archive_cmds} to affect generation of file "libtool" to fix linking with clang
put the configure.ac and .gitignore changes into an extra commit?
File doc/manuals/chapters/server.adoc:
Maybe worth document what happens if the system's localtime goes backward (daylight savings time or drifting and getting adjusted?)
Actually I'm wondering if that could lead to overwriting previous files, if going backwards 1h because of DST and you have e.g. "rotate-localtime minute". That could happen if the timestamp is part of the filename instead of an ever increasing number (not sure if that is the case, maybe also worth documenting here if it isn't in the docs yet).
File src/osmo_server_network.c:
Patch Set #3, Line 231: /* Checks if we are in a new record period since last time we wrote to a pcap, to know (return true) whether a new pcap file needs to be opened.
cosmetic: very long line
File src/osmo_server_vty.c:
Patch Set #3, Line 219: frecuency
frequency
Patch Set #3, Line 246: max_mod = 4294967295;
(that will take a while :D)
is there some constant we could use instead of this magic number? Same in DEFUN(cfg_server_rotate_localtime_mod_n.
To view, visit change 39158. To unsubscribe, or for help writing mail filters, visit settings.