Attention is currently required from: falconia, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32714 ) Change subject: TCH DL, FR & EFR: reshape SIDs per 06.31/06.81 section 5.1.2 ...................................................................... Patch Set 3: (3 comments) File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/32714/comment/216c7b57_9c92f025 PS3, Line 1308: static inline bool nonamr_mand_sid_position(struct gsm_lchan *lchan, fr_efr_sid_position() would be more inline with the rest. https://gerrit.osmocom.org/c/osmo-bts/+/32714/comment/ee4eba6c_b1d8cc0f PS3, Line 1415: } else missing {} in this else following a multiple line if. https://gerrit.osmocom.org/c/osmo-bts/+/32714/comment/e6d5bf8d_16ca3f34 PS3, Line 1441: if (!resp_msg && lchan->tch.dtx_fr_efr.last_rtp_input_was_sid && I'd welcome if you could give a try to see if you can simplify a bit these code paths below, even if that means repeating a bit of code. All of these code paths are full of complex conditionals being checked, some of them checked several times, like resp_msg. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32714 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I924ab21952dcf8bb03ba7ccef790474bf66fc9e5 Gerrit-Change-Number: 32714 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 16 May 2023 07:56:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment