Attention is currently required from: falconia, dexter.

View Change

3 comments:

• File src/common/l1sap.c:

  • Patch Set #3, Line 1308: static inline bool nonamr_mand_sid_position(struct gsm_lchan *lchan,

    fr_efr_sid_position() would be more inline with the rest.

  • Patch Set #3, Line 1415: } else

    missing {} in this else following a multiple line if.

  • Patch Set #3, Line 1441: if (!resp_msg && lchan->tch.dtx_fr_efr.last_rtp_input_was_sid &&

    I'd welcome if you could give a try to see if you can simplify a bit these code paths below, even if that means repeating a bit of code. All of these code paths are full of complex conditionals being checked, some of them checked several times, like resp_msg.

To view, visit change 32714. To unsubscribe, or for help writing mail filters, visit settings.