Attention is currently required from: fixeria, laforge.
jolly has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/35082?usp=email )
Change subject: LAPDm: Reject (release) establishment on DCC0, SAPI 0 without L3 payload
......................................................................
Patch Set 2:
(1 comment)
File src/common/rsl.c:
https://gerrit.osmocom.org/c/osmo-bts/+/35082/comment/e0478ddf_76a91bf6
PS1, Line 3839: if (msgb_l2len(msg) == sizeof(*rllh) && (rllh->link_id &
0xc7) == 0x00) {
Using our union abis_rsl_link_id and then comparing
sapin and cbits individually is probably the mor […]
I agree.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/35082?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I6819b51a876b8743c2d4a04165b7900723a1631c
Gerrit-Change-Number: 35082
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 22 Nov 2023 14:08:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment