Attention is currently required from: laforge, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/31431 ) Change subject: context map: introduce RUA and SCCP FSMs to fix leaks ...................................................................... Patch Set 5: (2 comments) File include/osmocom/hnbgw/context_map.h: https://gerrit.osmocom.org/c/osmo-hnbgw/+/31431/comment/9590d2bc_29e51994 PS5, Line 22: enum map_rua_fsm_event { (hold on, the PLEASE_DISCONNECT should not be there anymore. Leftover from an intermediate patch state. will fix.) RUA_EV_RX_ means a RUA PDU has arrived from HNB. SCCP_EV_RX_ means an SCCP PDU has arrived from CN. the _EV_TX_ means that one FSM asks the other to forward a RANAP PDU to the remote peer. I am not entirely clear how to apply the OSI terms to the FSM event names. So in the SCCP code, - the SCCP N_DATA towards CN is always sent as an N-Data.Request prim to osmo_sccp_user_sap_down(). - From the CN, we always receive an N-Data.Indication In the RUA API, these terms apparently are not used. At least I don't see them in the code. Would this be correct? RUA HNBGW SCCP CN | --MAP_SCCP_EV_TX_REQUEST----> | --N-Data.Request-> | | <--MAP_RUA_EV_TX_INDICATION-- | <-N-Data.Ind------ | (I want the "RX" name to be reserved for PDUs from a remote peer, and "TX" for PDU forwarding between internal FSMs.) File src/osmo-hnbgw/hnbgw_rua.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/31431/comment/bce704c5_aec1ff88 PS5, Line 183: { RUA_ProcedureCode_id_Connect, "id-Connect" }, ah ok, was not aware of that! -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31431 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I6ff7e36532ff57c6f2d3e7e419dd22ef27dafd19 Gerrit-Change-Number: 31431 Gerrit-PatchSet: 5 Gerrit-Owner: neels &lt;nhofmeyr(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-CC: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Comment-Date: Tue, 21 Feb 2023 22:07:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels &lt;nhofmeyr(a)sysmocom.de&gt; Comment-In-Reply-To: laforge &lt;laforge(a)osmocom.org&gt; Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-MessageType: comment