Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38166?usp=email ) Change subject: pySim-prog: rework documentation ...................................................................... Patch Set 1: (3 comments) File docs/legacy.rst: https://gerrit.osmocom.org/c/pysim/+/38166/comment/38cd3a96_1a4f3de6?usp=em… : PS1, Line 46: KI, OPc depends on whether we merge the patch you just added to derive those from the 'secret'... https://gerrit.osmocom.org/c/pysim/+/38166/comment/12cbdc88_71e22aab?usp=em… : PS1, Line 62: * supersim : * magicsim : * fakemagicsim : * grcardsim : * sysmosim-gr1 : * sysmoSIM-GR2 : * sysmoUSIM-SJS1 : * Fairwaves-SIM : * OpenCells-SIM : * Wavemobile-SIM : * sysmoISIM-SJA2 : * sysmoISIM-SJA5 : * gialersim I guess those should be alphabetically sorted? https://gerrit.osmocom.org/c/pysim/+/38166/comment/df312d9f_53caae9c?usp=em… : PS1, Line 110: , extra comma should probably be removed -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38166?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I1d1a65154cea7fa77428b412fcf8c7b4cba629b1 Gerrit-Change-Number: 38166 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Sep 2024 10:54:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No