fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35310?usp=email )
Change subject: virt_phy: fix checking stderr_target in ms_log_init() ......................................................................
virt_phy: fix checking stderr_target in ms_log_init()
Checking the stderr makes a little sense, since it's an integer value (usually equal to 2). The actual intention, most likely, was to check 'stderr_target' against NULL.
Change-Id: Id597f766142f928135f9fd2b7cf4d69de7bc72f0 Related: OS#6299 --- M src/host/virt_phy/src/logging.c 1 file changed, 15 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/10/35310/1
diff --git a/src/host/virt_phy/src/logging.c b/src/host/virt_phy/src/logging.c index 0a1b2a4..19951ef 100644 --- a/src/host/virt_phy/src/logging.c +++ b/src/host/virt_phy/src/logging.c @@ -113,8 +113,7 @@
log_init(&ms_log_info, NULL); stderr_target = log_target_create_stderr(); - if (!stderr) - return -1; + OSMO_ASSERT(stderr_target != NULL);
log_add_target(stderr_target); log_set_all_filter(stderr_target, 1);