Attention is currently required from: fixeria, laforge.
dexter has posted comments on this change by dexter. (
https://gerrit.osmocom.org/c/pysim/+/37840?usp=email )
Change subject: ara_m: use class byte of current lchan
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS6:
I think if you make apply_lchan=True the default (to
which I agree!), then you have to audit the exi […]
This is interesting. I have
looked up MANAGE CHANNEL in ETSI TS 102.221. I could not find any hint that MANAGE CHANNEL
has to be exclusively used on lchan 0. Also when I look at the code [1] it seems that we
already use the CLA byte of the lchan for MANAGE CHANNEL. I wonder if I am
misunderstanding something here.
[1]
https://gitea.osmocom.org/sim-card/pysim/src/branch/master/pySim/commands.p…
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/37840?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ie3e48678f178a488bfaea6cc2b9a3e18145a8d10
Gerrit-Change-Number: 37840
Gerrit-PatchSet: 7
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 23 Aug 2024 15:36:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>