pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/39360?usp=email ) Change subject: osmo_io: segmentation: Remove unneeded impossible check ...................................................................... osmo_io: segmentation: Remove unneeded impossible check The rc <= 0 case is already early returned above. Change-Id: I9316730aeaf7c7efd3ea8965ab43fa21f844260c --- M src/core/osmo_io.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/60/39360/1 diff --git a/src/core/osmo_io.c b/src/core/osmo_io.c index 45aaef3..15703cf 100644 --- a/src/core/osmo_io.c +++ b/src/core/osmo_io.c @@ -343,7 +343,7 @@ do { pending = NULL; res = iofd_handle_segmentation(iofd, msg, &pending); - if (res != IOFD_SEG_ACT_DEFER || rc < 0) { + if (res != IOFD_SEG_ACT_DEFER) { iofd->io_ops.read_cb(iofd, rc, msg); /* The user could unregister/close the iofd during read_cb() above. * Once that's done, it doesn't expect to receive any more events, -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39360?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9316730aeaf7c7efd3ea8965ab43fa21f844260c Gerrit-Change-Number: 39360 Gerrit-PatchSet: 1 Gerrit-Owner: pespin &lt;pespin(a)sysmocom.de&gt;