Attention is currently required from: msuraev, lynxis lazus. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/29714 )

Change subject: gbproxy_vty: Add commands to list Cell/BVC of an NSE ......................................................................

Patch Set 2:

(1 comment)

File src/gb_proxy_vty.c:

https://gerrit.osmocom.org/c/osmo-gbproxy/+/29714/comment/5d496b7e_b23bf68a PS2, Line 543: int i;

Would be better to use "unsigned" or "size_t" for i: it's iterated from 0 and used as array index in […]

I don't completely disagree, but in the macro bkt is initialized to 0 and checked against ARRAY_SIZE of the array. So as long as the array will not use more than 2^31 elements this shouldn't matter in practice.

int is also used in hash_for_each loops in several existing functions (above and below).

Let's leave this patch as-is, if you want you could provide a follow-up patch changing all occurrences.