Change in osmo-ttcn3-hacks[master]: bsc: move as_Media arg fail_on_dlcx to pars - gerrit-log

16 Feb 2023


      Attention is currently required from: osmith, laforge, pespin.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31337 )
Change subject: bsc: move as_Media arg fail_on_dlcx to pars
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Patchset:
PS1:
...
Right, the previous version would allow running as_Media() multiple times, once with fail_on_dlcx := […]
personally i like to see explicitly that fail_on_dlcx == true ... but then again someone else may argue that it is nice to see the config all in one place at the start of the test. I think I would have kept it as explicit arg, but fine =)
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31337
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6f0c4ce543724cc6f18bae9fc2b480f5818db8b7
Gerrit-Change-Number: 31337
Gerrit-PatchSet: 2
Gerrit-Owner: osmith osmith@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: neels nhofmeyr@sysmocom.de
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: osmith osmith@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Thu, 16 Feb 2023 13:47:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith osmith@sysmocom.de
Comment-In-Reply-To: pespin pespin@sysmocom.de
Gerrit-MessageType: comment