Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918 ) Change subject: import latest e1-tracer host software ...................................................................... Patch Set 4: (30 comments) File software/e1-tracer/crc4itu.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/c72f8a80_df59… PS4, Line 65: typedef uint_fast8_t crc_t; do not add new typedefs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/802b055d_2377… PS4, Line 75: return 0x0; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/dd3a2d80_2084… PS4, Line 98: return crc; please, no spaces at the start of a line File software/e1-tracer/crc4itu.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/14a9eadf_ee8d… PS4, Line 26: 0x00, 0x03, 0x06, 0x05, 0x0c, 0x0f, 0x0a, 0x09, 0x0b, 0x08, 0x0d, 0x0e, 0x07, 0x04, 0x01, 0x02, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/ef28d973_357b… PS4, Line 27: 0x05, 0x06, 0x03, 0x00, 0x09, 0x0a, 0x0f, 0x0c, 0x0e, 0x0d, 0x08, 0x0b, 0x02, 0x01, 0x04, 0x07, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/7bf0a975_c86a… PS4, Line 28: 0x0a, 0x09, 0x0c, 0x0f, 0x06, 0x05, 0x00, 0x03, 0x01, 0x02, 0x07, 0x04, 0x0d, 0x0e, 0x0b, 0x08, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/b5fe2b6a_642f… PS4, Line 29: 0x0f, 0x0c, 0x09, 0x0a, 0x03, 0x00, 0x05, 0x06, 0x04, 0x07, 0x02, 0x01, 0x08, 0x0b, 0x0e, 0x0d, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/b82ef874_225e… PS4, Line 30: 0x07, 0x04, 0x01, 0x02, 0x0b, 0x08, 0x0d, 0x0e, 0x0c, 0x0f, 0x0a, 0x09, 0x00, 0x03, 0x06, 0x05, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/be667b77_80a2… PS4, Line 31: 0x02, 0x01, 0x04, 0x07, 0x0e, 0x0d, 0x08, 0x0b, 0x09, 0x0a, 0x0f, 0x0c, 0x05, 0x06, 0x03, 0x00, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/59c266c0_54f5… PS4, Line 32: 0x0d, 0x0e, 0x0b, 0x08, 0x01, 0x02, 0x07, 0x04, 0x06, 0x05, 0x00, 0x03, 0x0a, 0x09, 0x0c, 0x0f, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/51ea5972_a705… PS4, Line 33: 0x08, 0x0b, 0x0e, 0x0d, 0x04, 0x07, 0x02, 0x01, 0x03, 0x00, 0x05, 0x06, 0x0f, 0x0c, 0x09, 0x0a, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/57738c1d_798c… PS4, Line 34: 0x0e, 0x0d, 0x08, 0x0b, 0x02, 0x01, 0x04, 0x07, 0x05, 0x06, 0x03, 0x00, 0x09, 0x0a, 0x0f, 0x0c, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/22e4a443_4fe6… PS4, Line 35: 0x0b, 0x08, 0x0d, 0x0e, 0x07, 0x04, 0x01, 0x02, 0x00, 0x03, 0x06, 0x05, 0x0c, 0x0f, 0x0a, 0x09, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/68946cd6_4944… PS4, Line 36: 0x04, 0x07, 0x02, 0x01, 0x08, 0x0b, 0x0e, 0x0d, 0x0f, 0x0c, 0x09, 0x0a, 0x03, 0x00, 0x05, 0x06, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/dc4b2485_f5c0… PS4, Line 37: 0x01, 0x02, 0x07, 0x04, 0x0d, 0x0e, 0x0b, 0x08, 0x0a, 0x09, 0x0c, 0x0f, 0x06, 0x05, 0x00, 0x03, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/4e0c3e92_a295… PS4, Line 38: 0x09, 0x0a, 0x0f, 0x0c, 0x05, 0x06, 0x03, 0x00, 0x02, 0x01, 0x04, 0x07, 0x0e, 0x0d, 0x08, 0x0b, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/257b4f2f_d035… PS4, Line 39: 0x0c, 0x0f, 0x0a, 0x09, 0x00, 0x03, 0x06, 0x05, 0x07, 0x04, 0x01, 0x02, 0x0b, 0x08, 0x0d, 0x0e, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/83748e68_614a… PS4, Line 40: 0x03, 0x00, 0x05, 0x06, 0x0f, 0x0c, 0x09, 0x0a, 0x08, 0x0b, 0x0e, 0x0d, 0x04, 0x07, 0x02, 0x01, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/b232d847_0151… PS4, Line 41: 0x06, 0x05, 0x00, 0x03, 0x0a, 0x09, 0x0c, 0x0f, 0x0d, 0x0e, 0x0b, 0x08, 0x01, 0x02, 0x07, 0x04 please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/a4ac5729_5f3c… PS4, Line 47: const unsigned char *d = (const unsigned char *)data; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/98da119d_423d… PS4, Line 48: unsigned int tbl_idx; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/930b84c8_c8e8… PS4, Line 50: while (data_len--) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/1b6f8ff8_1318… PS4, Line 51: tbl_idx = (crc << 4) ^ *d; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/2a9ddaf9_566f… PS4, Line 51: tbl_idx = (crc << 4) ^ *d; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/f8d73321_43d9… PS4, Line 52: crc = crc_table[tbl_idx] & 0xf; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/d136c998_881c… PS4, Line 52: crc = crc_table[tbl_idx] & 0xf; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/716ca82b_5b32… PS4, Line 53: d++; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/c377b30d_3427… PS4, Line 53: d++; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/0cda26cc_6c5e… PS4, Line 54: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/1dba0954_f7cb… PS4, Line 55: return crc & 0xf; please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: I9319c1eb8f822830307c1a181d357c58ce43efba Gerrit-Change-Number: 29918 Gerrit-PatchSet: 4 Gerrit-Owner: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Mon, 31 Oct 2022 07:27:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment