30 comments:
File software/e1-tracer/crc4itu.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578):
Patch Set #4, Line 65: typedef uint_fast8_t crc_t;
do not add new typedefs
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578):
Patch Set #4, Line 75: return 0x0;
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578):
Patch Set #4, Line 98: return crc;
please, no spaces at the start of a line
File software/e1-tracer/crc4itu.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578):
Patch Set #4, Line 26: 0x00, 0x03, 0x06, 0x05, 0x0c, 0x0f, 0x0a, 0x09, 0x0b, 0x08, 0x0d, 0x0e, 0x07, 0x04, 0x01, 0x02,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578):
Patch Set #4, Line 27: 0x05, 0x06, 0x03, 0x00, 0x09, 0x0a, 0x0f, 0x0c, 0x0e, 0x0d, 0x08, 0x0b, 0x02, 0x01, 0x04, 0x07,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578):
Patch Set #4, Line 28: 0x0a, 0x09, 0x0c, 0x0f, 0x06, 0x05, 0x00, 0x03, 0x01, 0x02, 0x07, 0x04, 0x0d, 0x0e, 0x0b, 0x08,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578):
Patch Set #4, Line 29: 0x0f, 0x0c, 0x09, 0x0a, 0x03, 0x00, 0x05, 0x06, 0x04, 0x07, 0x02, 0x01, 0x08, 0x0b, 0x0e, 0x0d,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578):
Patch Set #4, Line 30: 0x07, 0x04, 0x01, 0x02, 0x0b, 0x08, 0x0d, 0x0e, 0x0c, 0x0f, 0x0a, 0x09, 0x00, 0x03, 0x06, 0x05,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578):
Patch Set #4, Line 31: 0x02, 0x01, 0x04, 0x07, 0x0e, 0x0d, 0x08, 0x0b, 0x09, 0x0a, 0x0f, 0x0c, 0x05, 0x06, 0x03, 0x00,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578):
Patch Set #4, Line 32: 0x0d, 0x0e, 0x0b, 0x08, 0x01, 0x02, 0x07, 0x04, 0x06, 0x05, 0x00, 0x03, 0x0a, 0x09, 0x0c, 0x0f,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578):
Patch Set #4, Line 33: 0x08, 0x0b, 0x0e, 0x0d, 0x04, 0x07, 0x02, 0x01, 0x03, 0x00, 0x05, 0x06, 0x0f, 0x0c, 0x09, 0x0a,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578):
Patch Set #4, Line 34: 0x0e, 0x0d, 0x08, 0x0b, 0x02, 0x01, 0x04, 0x07, 0x05, 0x06, 0x03, 0x00, 0x09, 0x0a, 0x0f, 0x0c,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578):
Patch Set #4, Line 35: 0x0b, 0x08, 0x0d, 0x0e, 0x07, 0x04, 0x01, 0x02, 0x00, 0x03, 0x06, 0x05, 0x0c, 0x0f, 0x0a, 0x09,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578):
Patch Set #4, Line 36: 0x04, 0x07, 0x02, 0x01, 0x08, 0x0b, 0x0e, 0x0d, 0x0f, 0x0c, 0x09, 0x0a, 0x03, 0x00, 0x05, 0x06,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578):
Patch Set #4, Line 37: 0x01, 0x02, 0x07, 0x04, 0x0d, 0x0e, 0x0b, 0x08, 0x0a, 0x09, 0x0c, 0x0f, 0x06, 0x05, 0x00, 0x03,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578):
Patch Set #4, Line 38: 0x09, 0x0a, 0x0f, 0x0c, 0x05, 0x06, 0x03, 0x00, 0x02, 0x01, 0x04, 0x07, 0x0e, 0x0d, 0x08, 0x0b,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578):
Patch Set #4, Line 39: 0x0c, 0x0f, 0x0a, 0x09, 0x00, 0x03, 0x06, 0x05, 0x07, 0x04, 0x01, 0x02, 0x0b, 0x08, 0x0d, 0x0e,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578):
Patch Set #4, Line 40: 0x03, 0x00, 0x05, 0x06, 0x0f, 0x0c, 0x09, 0x0a, 0x08, 0x0b, 0x0e, 0x0d, 0x04, 0x07, 0x02, 0x01,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578):
Patch Set #4, Line 41: 0x06, 0x05, 0x00, 0x03, 0x0a, 0x09, 0x0c, 0x0f, 0x0d, 0x0e, 0x0b, 0x08, 0x01, 0x02, 0x07, 0x04
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578):
Patch Set #4, Line 47: const unsigned char *d = (const unsigned char *)data;
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578):
Patch Set #4, Line 48: unsigned int tbl_idx;
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578):
Patch Set #4, Line 50: while (data_len--) {
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578):
Patch Set #4, Line 51: tbl_idx = (crc << 4) ^ *d;
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578):
Patch Set #4, Line 51: tbl_idx = (crc << 4) ^ *d;
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578):
Patch Set #4, Line 52: crc = crc_table[tbl_idx] & 0xf;
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578):
Patch Set #4, Line 52: crc = crc_table[tbl_idx] & 0xf;
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578):
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578):
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578):
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-578):
Patch Set #4, Line 55: return crc & 0xf;
please, no spaces at the start of a line
To view, visit change 29918. To unsubscribe, or for help writing mail filters, visit settings.