Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37955?usp=email ) Change subject: Introduce initial metrics support ...................................................................... Patch Set 4: (4 comments) Commit Message: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37955/comment/5104472b_25aa… : PS4, Line 2: Vadim Yanitskiy <vyanitskiy(a)sysmocom.de> Not sure why/how git changed the Author, I'll revert this. File include/s1gw_metrics.hrl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37955/comment/5b0ba42b_a1ad… : PS3, Line 9: S1GW_CTR_S1AP_PROXY_IN_PKT This one was not referenced anywhere, so I removed it. https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37955/comment/b97c48bb_6bb0… : PS3, Line 12: S1GW_CTR_S1AP_PROXY_IN_PKT_UNMODIFIED I moved this one down below and renamed to `S1GW_CTR_S1AP_PROXY_OUT_PKT_FWD_UNMODIFIED`. The point is that it's not related to the input path, but to the output path. https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37955/comment/e6a374e0_7075… : PS3, Line 14: S1GW_CTR_S1AP_PROXY_IN_PKT_ERAB_SETUP_REQ_FAILED Renamed to `S1GW_CTR_S1AP_PROXY_OUT_PKT_REPLY_ERAB_SETUP_RSP`, see below. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37955?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I952e198238384dca4be94f91a01d7cfff0a1471f Gerrit-Change-Number: 37955 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Sep 2024 07:52:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No