Attention is currently required from: dexter.
laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38118?usp=email )
Change subject: utils: get rid of enc_msisdn and dec_msisdn
......................................................................
Patch Set 8: Code-Review-1
(1 comment)
Patchset:
PS8:
as the tests indicate it also changes the output of the tests with real cards. I'd vote to simply move the {enc,dec}_msisdn to pySim.legacy and not change anything except the import statements in legacy tools.
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/38118?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I19ec8ba14551ec282fc0cc12ae2f6d528bdfc527
Gerrit-Change-Number: 38118
Gerrit-PatchSet: 8
Gerrit-Owner: dexter
pmaier@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Attention: dexter
pmaier@sysmocom.de
Gerrit-Comment-Date: Thu, 19 Sep 2024 04:39:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes