Attention is currently required from: pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-pcu/+/39698?usp=email )
Change subject: tests/alloc: alloc_tbfs(): fix always true condition
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Looks like something needs fixing in this patch.
Would you like to take a look? I saw a warning while compiling with clang, saying that the assert condition is always true because `uint8_t` cannot be `-1`:
```
// note that trx_no here is implicitly casted to an int here
OSMO_ASSERT(trx_no != -1 || bts_all_pdch_allocated(bts));
```
--
To view, visit
https://gerrit.osmocom.org/c/osmo-pcu/+/39698?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ia345938512a2f4f92523596beb19d7c127a8a601
Gerrit-Change-Number: 39698
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-CC: pespin
pespin@sysmocom.de
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Comment-Date: Wed, 05 Mar 2025 18:36:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
pespin@sysmocom.de