Attention is currently required from: daniel.
pespin has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40282?usp=email )
Change subject: sccp: Introduce LOGPSCI() log macro
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Could you provide a sample log line in the commit
message?
0: SCCP(rctx=0) sccp_scrc_rx_sclc_msg: HDR=(CL:CLDT,V=0,LEN=0),
PART(T=Routing Context,L=4,D=00000000), PART(T=Protocol Class,L=4,D=00000000),
PART(T=Source Address,L=20,D=0002000380020008000000bd800300080000008e), PART(T=Destination
Address,L=20,D=0002000380020008000000bc800300080000008e), PART(T=Sequence
Control,L=4,D=00000000),
PART(T=Data,L=26,D=00090016000003000440011000030001000056400500f1100017)
We can always improve as needed the macro. At least we now get more uniform output with at
least some context.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40282?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I0f04ff064d3693c6d71aa4977e0c593c7f157f7e
Gerrit-Change-Number: 40282
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 12 May 2025 16:18:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>