Attention is currently required from: matanp.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/32686 )
Change subject: cards: Add support for Gialer SIM cards ......................................................................
Patch Set 1:
(2 comments)
File pySim/cards.py:
https://gerrit.osmocom.org/c/pysim/+/32686/comment/328a7833_23be1b4c PS1, Line 1668: def autodetect(kls, scc): isn't it possible to auto-detect the cards based on ATR or some other criteria?
https://gerrit.osmocom.org/c/pysim/+/32686/comment/74774617_d27882db PS1, Line 1700: are you sure there aren't various other files you'd need to program? Like EF.AD for 2/3-digit MNC, etc.
Also, the product homepage states the product is a USIM, but you'r eonly adding GSM Ki here, no K/OPC. Is that intended?
-
laforge