Attention is currently required from: pespin. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30972 )
Change subject: layer23: Move '(no) shutdown' VTY code to common/vty.c ......................................................................
Patch Set 2:
(2 comments)
File doc/examples/modem/modem.cfg:
https://gerrit.osmocom.org/c/osmocom-bb/+/30972/comment/42ae3f1e_f02c72de PS2, Line 1: ! Unrelated change?
File src/host/layer23/include/osmocom/bb/common/osmocom_data.h:
https://gerrit.osmocom.org/c/osmocom-bb/+/30972/comment/5320fdb3_5ea5cafc PS2, Line 37: struct osmobb_l23_vty_sig_data { Why separate substructs for start/stop? The commands using them are mutually exclusive so single 'struct {...} ms' should suffice.