Attention is currently required from: neels, osmith.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35179?usp=email )

Change subject: socket: Introduce API osmo_sock_multiaddr_get_ip_and_port() ......................................................................

Patch Set 4:

(7 comments)

File src/core/socket.c:

https://gerrit.osmocom.org/c/libosmocore/+/35179/comment/e21aa3ab_8a5bd2ac PS1, Line 1810: /*! Get the IP and/or port number on socket in separate string buffers.

Ack

Done

https://gerrit.osmocom.org/c/libosmocore/+/35179/comment/9fcdd5c0_afa3cad6 PS1, Line 1819: * \returns 0 on success; negative otherwise

Yes, you pass char ip[CNT][LEN]. You pass it as "&ip[0][0]". Number of CNT is passed in ip_cnt. […]

Done

https://gerrit.osmocom.org/c/libosmocore/+/35179/comment/cc4e5eaf_99dfbe1e PS1, Line 1843: c

Ack

Done

https://gerrit.osmocom.org/c/libosmocore/+/35179/comment/25fdbc3d_7128ca45 PS1, Line 1870: local ? sctp_freeladdrs(addrs) : sctp_freepaddrs(addrs);

I'm not sure what's new for you here? the fact that you can use a tri operator with functions return […]

Done

https://gerrit.osmocom.org/c/libosmocore/+/35179/comment/cbbe4676_c98bb647 PS1, Line 1874: *

Ack

Done

https://gerrit.osmocom.org/c/libosmocore/+/35179/comment/110b505b_eeb8b197 PS1, Line 1878: local ? sctp_freeladdrs(addrs) : sctp_freepaddrs(addrs);

I'll see if it looks better that way.

Done

File src/core/socket.c:

https://gerrit.osmocom.org/c/libosmocore/+/35179/comment/2c5076fe_f0e254df PS2, Line 1827: * char hostbuf[32][INET6_ADDRSTRLEN];

I need to s/32/OSMO_SOCK_MAX_ADDRS/g here.

Done