Attention is currently required from: neels, osmith.

View Change

7 comments:

• File src/core/socket.c:

  • Patch Set #1, Line 1810: /*! Get the IP and/or port number on socket in separate string buffers.

    Ack

    Done

  • Patch Set #1, Line 1819: * \returns 0 on success; negative otherwise

    Yes, you pass char ip[CNT][LEN]. You pass it as "&ip[0][0]". Number of CNT is passed in ip_cnt. […]

    Done

  • Patch Set #1, Line 1843: c

    Ack

    Done

  • Patch Set #1, Line 1870: local ? sctp_freeladdrs(addrs) : sctp_freepaddrs(addrs);

    I'm not sure what's new for you here? the fact that you can use a tri operator with functions return […]

    Done

  • Patch Set #1, Line 1874: *

    Ack

    Done

  • Patch Set #1, Line 1878: local ? sctp_freeladdrs(addrs) : sctp_freepaddrs(addrs);

    I'll see if it looks better that way.

    Done

• File src/core/socket.c:

  • Patch Set #2, Line 1827: * char hostbuf[32][INET6_ADDRSTRLEN];

    I need to s/32/OSMO_SOCK_MAX_ADDRS/g here.

    Done

To view, visit change 35179. To unsubscribe, or for help writing mail filters, visit settings.