dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29705 )
Change subject: abis_rsl: delete CHAN RQD from queue when rach ind was sent ......................................................................
abis_rsl: delete CHAN RQD from queue when rach ind was sent
The CHAN REQ entry is not deleted after its information was passed on to the PCU. This causes the same entry to be used over and over again while blocking other incoming CHAN RQD.
Change-Id: Ia4abc55fc6fcb1c00991cc84d09529131d014910 Related: OS#5198 --- M src/osmo-bsc/abis_rsl.c 1 file changed, 4 insertions(+), 2 deletions(-)
Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified
diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index 3b83b0e..304e95c 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -2147,8 +2147,8 @@
/* Handle PDCH related rach requests (in case of BSC-co-located-PCU) */ if (rqd->reason == GSM_CHREQ_REASON_PDCH) { - rsl_rx_pchan_rqd(rqd); - return; + if (rsl_rx_pchan_rqd(rqd) == 0) + goto leave; }
/* Ensure that emergency calls will get priority over regular calls, however releasing @@ -2234,6 +2234,8 @@ };
lchan_activate(lchan, &info); + +leave: llist_del(&rqd->entry); talloc_free(rqd); return;