Attention is currently required from: osmith, Hoernchen, neels, laforge, fixeria, daniel.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30934 )
Change subject: Add osmo_io with initial poll backend ......................................................................
Patch Set 13:
(2 comments)
File src/core/osmo_io.c:
https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/918a8e10_308b954e PS13, Line 82: fprintf(stderr, "Invalid osmo_io backend requested: "%s\nCheck the environment variable %s\n", backend, OSMO_IO_BACKEND_ENV); You are missing a " before first \n.
File src/core/osmo_io_poll.c:
https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/8fb39dcd_9f3bee08 PS13, Line 93: if (rc < 0) { I think I changed this and you are changing it again. I really don't understand why are you doing this here. Is there some specific reason?) I also don't remember why exactly I changed it, but I recall there was a reason why I did so :/ I think this way you can, in the callback, actually dump the content of the message which is being dropped, which can be handy.