Attention is currently required from: osmith. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/34134 ) Change subject: pcuif_proto: get rid of _DT, _dt (Direct TLLI) ...................................................................... Patch Set 1: (1 comment) File include/osmocom/pcu/pcuif_proto.h: https://gerrit.osmocom.org/c/osmo-pcu/+/34134/comment/0c633798_06bb1a41 PS1, Line 21: #define PCU_IF_MSG_DATA_CNF_DT 0x11 /* confirm (using message id) */ The problem here is that osmo-pcu (current master) supports both PCUIF v.11 (the one we are currently developing) and PCUIF v.10. For v.10 we still need the old defines, structs etc. We intend to keel the PCUIF v.10 support for a while. The problem are the TTCN3 tests. If we change them to use v.11, then latest will fail. What we could do though is dropping the v.10 support some hours before the new release. Unfortunately changes to PCUIF are very complicated because we must touch osmo-pcu, osmo-bts, osmo-bsc, and the testsuite for osmo-pcu and osmo-bsc. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34134 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: If641b507dcb6b176109c99dce7cff2a7561364b0 Gerrit-Change-Number: 34134 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Aug 2023 15:18:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment