Attention is currently required from: arehbein, laforge.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-netif/+/35069?usp=email )
Change subject: stream_{cli,srv}: Add support for SCTP in OSMO_IO mode
......................................................................
Patch Set 5:
(2 comments)
File src/stream_cli.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/35069/comment/aee0a035_64754502
PS5, Line 474: .read_cb = stream_cli_iofd_read_cb,
Here for sctp we'd have a cmsg read cb, which would call something like
stream_sctp_recvmsg_wrapper() to transform it into what our regular sctp msgb look like.
https://gerrit.osmocom.org/c/libosmo-netif/+/35069/comment/7ca7433d_08a0fab6
PS5, Line 949: osmo_iofd_sctp_send_msgb(cli->iofd, msg, MSG_NOSIGNAL);
code here would here convert to cmsg API I mentioned in the osmo_io patch.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-netif/+/35069?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I6cf5bad5f618e71c80017960c38009b089dbd6a1
Gerrit-Change-Number: 35069
Gerrit-PatchSet: 5
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: arehbein <arehbein(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 27 Nov 2023 17:13:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment