laforge has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37105?usp=email )
Change subject: s1ap_proxy: add TODOs for PDUs also containing TLA ......................................................................
s1ap_proxy: add TODOs for PDUs also containing TLA
Change-Id: I1d420481cf78c75c2b7a7a3df5ffb1af1ba9aaa0 --- M src/s1ap_proxy.erl 1 file changed, 18 insertions(+), 0 deletions(-)
Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved
diff --git a/src/s1ap_proxy.erl b/src/s1ap_proxy.erl index 82e4039..d50d765 100644 --- a/src/s1ap_proxy.erl +++ b/src/s1ap_proxy.erl @@ -111,6 +111,8 @@ NewContent = Content#'E-RABSetupResponse'{protocolIEs = IEs}, handle_pdu_new(Data, {Outcome, Pdu#'SuccessfulOutcome'{value = NewContent}});
+%% TODO: 9.1.3.3 E-RAB MODIFY REQUEST / (Optional) Transport Information + %% 9.1.3.8 E-RAB MODIFICATION INDICATION handle_pdu(Data, {Outcome = initiatingMessage, #'InitiatingMessage'{procedureCode = ?'id-E-RABModificationIndication', @@ -144,6 +146,13 @@ NewContent = Content#'InitialContextSetupResponse'{protocolIEs = IEs}, handle_pdu_new(Data, {Outcome, Pdu#'SuccessfulOutcome'{value = NewContent}});
+%% TODO: 9.1.5.2 HANDOVER COMMAND :: (O) UL/DL Transport Layer Address +%% TODO: 9.1.5.4 HANDOVER REQUEST :: (M) Transport Layer Address +%% TODO: 9.1.5.5 HANDOVER REQUEST ACKNOWLEDGE :: (M) Transport Layer Address, +%% (O) UL/DL Transport Layer Address +%% TODO: 9.1.5.8 PATH SWITCH REQUEST :: (M) Transport Layer Address +%% TODO: 9.1.5.9 PATH SWITCH REQUEST ACKNOWLEDGE :: (M) Transport Layer Address + %% Proxy all other messages unmodified handle_pdu(Data, _Pdu) -> Data.