Attention is currently required from: neels, pespin, msuraev. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30972 )
Change subject: layer23: Move '(no) shutdown' VTY code to common/vty.c ......................................................................
Patch Set 4: Code-Review+1
(3 comments)
Patchset:
PS4: LGTM besides the unresolved comment
File doc/examples/modem/modem.cfg:
https://gerrit.osmocom.org/c/osmocom-bb/+/30972/comment/f3ebaeca_94c48be2 PS2, Line 1: !
It's not unrelated. […]
Done
File src/host/layer23/include/osmocom/bb/common/osmocom_data.h:
https://gerrit.osmocom.org/c/osmocom-bb/+/30972/comment/b0832ece_228e519d PS2, Line 37: struct osmobb_l23_vty_sig_data {
because more commands will probably be added later. […]
still unresolved, the union wasn't added yet
-
osmith