Attention is currently required from: fixeria, jolly, laforge.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34626?usp=email )

Change subject: ASCI: Add System Information 10 support ......................................................................

Patch Set 4:

(2 comments)

File src/osmo-bsc/system_information.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/34626/comment/16ca84fe_5f42e97f PS2, Line 1499: /* Do spare padding. We cannot do it earlier, because encoding might corrupt it if differenctial cell info

Indeed, SI10 employs so-called differential encoding: you encode all the info for the first BTS and […]

So if you mean "differential", then please use the correct spelling.

File src/osmo-bsc/system_information.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/34626/comment/53519a82_0964f4bf PS4, Line 1456: llist_for_each_entry(c, &conn->vgcs_chan.call->vgcs_call.chan_list, vgcs_chan.list) { "struct gsm_bts *c_bts;" can be moved here (loop scope).