Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27475 ) Change subject: sccp_sap_up_ran: ignore RAN until MSC is connected ...................................................................... Patch Set 1: (2 comments) File include/osmocom/bsc_nat/msc_fsm.h: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27475/comment/753c1610_c38fc7df PS1, Line 24: bool msc_fsm_is_connected(struct msc *msc); I see lots of functions msc_fsm_* being used in lots of places, even outside "msc" object. IMHO whether this is in the FSM or not inside the msc object is implementation specific, and all this functions would be far better being called msc_* instead of msc_fsm_* (except msc_fsm_alloc, which can be used inside the msc object msc_alloc() function, but you could really simply create the FSM directly in themsc_alloc() function). File src/osmo-bsc-nat/bsc_nat_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27475/comment/0bfd603f_9de5be6c PS1, Line 218: if (!msc_fsm_is_connected(msc)) { msc_is_connected. I don't care about fsm internals here. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27475 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: Idf9501412484fa92e8836952609fba7c5443d6c9 Gerrit-Change-Number: 27475 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Mar 2022 15:23:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment