Attention is currently required from: osmith.

View Change

2 comments:

• File include/osmocom/bsc_nat/msc_fsm.h:

  • Patch Set #1, Line 24: bool msc_fsm_is_connected(struct msc *msc);

    I see lots of functions msc_fsm_* being used in lots of places, even outside "msc" object. IMHO whether this is in the FSM or not inside the msc object is implementation specific, and all this functions would be far better being called msc_* instead of msc_fsm_* (except msc_fsm_alloc, which can be used inside the msc object msc_alloc() function, but you could really simply create the FSM directly in themsc_alloc() function).

• File src/osmo-bsc-nat/bsc_nat_fsm.c:

  • Patch Set #1, Line 218: if (!msc_fsm_is_connected(msc)) {

    msc_is_connected. I don't care about fsm internals here.

To view, visit change 27475. To unsubscribe, or for help writing mail filters, visit settings.