Attention is currently required from: daniel, pespin.

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37866?usp=email )

Change subject: Implement correct Routing Area based paging ......................................................................

Patch Set 11:

(2 comments)

This change is ready for review.

File src/sgsn/gprs_routing_area.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/37866/comment/3dc5f520_9d47c303?usp... : PS5, Line 319: }

/* TODO for UTRAN */ here I guess?

no the function is only called for geran.

File src/sgsn/sgsn_vty.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/37866/comment/32a24da3_275ac431?usp... : PS5, Line 1338: rate_ctr_inc(rate_ctr_group_get_ctr(mm->ctrg, GMM_CTR_PAGING_PS));

I don't really like the fact that now we have this counter incremented in several places. […]

I agree, but this should go into another commit.