Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32567 ) Change subject: layer23: modem: Delay GPRS attach at startup until modem is ready ...................................................................... Patch Set 1: (2 comments) File src/host/layer23/include/osmocom/bb/modem/modem.h: https://gerrit.osmocom.org/c/osmocom-bb/+/32567/comment/4638b6a3_350a9a42 PS1, Line 12: }; It may become a full osmo_fsm at some point, or even not, or even several FSMs, or god knows. I still need to figure out some stuff and for now I simply prefer having something minimal working which allows to test the entire thing and I can then understand the whole system better. At some point we may want to move this to an FSM (or not). Right now, adding an FSM is a lot of boilerplate I want to avoid. File src/host/layer23/src/modem/app_modem.c: https://gerrit.osmocom.org/c/osmocom-bb/+/32567/comment/a2f88d63_313dc1cf PS1, Line 83: LOGP(DRLCMAC, LOGL_INFO, "Delaying GPRS attach, waiting for:%s%s%s%s%s%s\n", No, I want to keep it here since I want to have all the logic together. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32567 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I5029d9e8a47b8544b3b803c4db6352269bac3c0e Gerrit-Change-Number: 32567 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 03 May 2023 14:05:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment