Attention is currently required from: osmith.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32567 )

Change subject: layer23: modem: Delay GPRS attach at startup until modem is ready ......................................................................

Patch Set 1:

(2 comments)

File src/host/layer23/include/osmocom/bb/modem/modem.h:

https://gerrit.osmocom.org/c/osmocom-bb/+/32567/comment/4638b6a3_350a9a42 PS1, Line 12: };

what's the rationale behind not using a full osmo_fsm?

It may become a full osmo_fsm at some point, or even not, or even several FSMs, or god knows. I still need to figure out some stuff and for now I simply prefer having something minimal working which allows to test the entire thing and I can then understand the whole system better. At some point we may want to move this to an FSM (or not). Right now, adding an FSM is a lot of boilerplate I want to avoid.

File src/host/layer23/src/modem/app_modem.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/32567/comment/a2f88d63_313dc1cf PS1, Line 83: LOGP(DRLCMAC, LOGL_INFO, "Delaying GPRS attach, waiting for:%s%s%s%s%s%s\n",

How about moving this log message into modem_gprs_attach_if_needed()? From the function names this w […]

No, I want to keep it here since I want to have all the logic together.