Attention is currently required from: laforge, osmith, pespin.

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35242?usp=email )

Change subject: vty: Retrieve IP addr set from sk when dumping xUA server ......................................................................

Patch Set 2:

(3 comments)

Commit Message:

https://gerrit.osmocom.org/c/libosmo-sccp/+/35242/comment/54aa6804_87285fe5 PS2, Line 14: osmo_stream_srv_link_get_sockname `<error-not-a-valid-change-id>` ;)

File src/osmo_ss7_vty.c:

https://gerrit.osmocom.org/c/libosmo-sccp/+/35242/comment/ae48497c_8fa25d68 PS2, Line 629: <error> May we let the VTY user know a bit more than:

``` xUA server for %s on <error> is listening ```

Maybe be more verbose and print an error message here?

Alternatively, we can rephrase a bit and print each address on new line maybe?

``` xUA server for %s is listening on: ADDR:PORT ADDR:PORT ADDR:PORT (+N addresses more)

xUA server for %s is listening on: (could not retrieve listening address(es) due to an error) ```

https://gerrit.osmocom.org/c/libosmo-sccp/+/35242/comment/94f53d63_9413d8da PS2, Line 632: num_hostbuf = ARRAY_SIZE(hostbuf);

in https://gerrit.osmocom. […]

From the user perspective, it would be more practical to see those which fit into the buffer, and some error message like `(+N addresses more)...`.