Attention is currently required from: fixeria, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30950 ) Change subject: layer23: Add initial VTY support for l23_apps ...................................................................... Patch Set 5: (2 comments) File src/host/layer23/src/common/main.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30950/comment/3c8873f6_92b6e33b PS1, Line 271: handle_options NB, this is about "l23_app_init()", not "_info()". i agree with fixeria: there is logging in the l23_app_init() code path, and it even sends out a msgb via osmo_send_l1(). it seems clear that this should happen *after* we parsed all cmdline and vty cfg. File src/host/layer23/src/common/main.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30950/comment/15cc4fda_aca3b9e6 PS5, Line 177: config_file = optarg; this is also removing two cmdline options, is that intended? it is not mentioned in the commit log, seems better as a separate patch -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30950 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ife3a3373e5a9c0c8e5959ac714e140e72d6c363a Gerrit-Change-Number: 30950 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 15 Jan 2023 22:57:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment