Attention is currently required from: fixeria, pespin.

View Change

2 comments:

• File src/host/layer23/src/common/main.c:

  • Patch Set #1, Line 271: handle_options

    It doesn't take VTY config anyway. It's chicken an egg problem we have in all apps. […]

    NB, this is about "l23_app_init()", not "_info()".

    i agree with fixeria: there is logging in the l23_app_init() code path, and it even sends out a msgb via osmo_send_l1(). it seems clear that this should happen *after* we parsed all cmdline and vty cfg.

• File src/host/layer23/src/common/main.c:

  • Patch Set #5, Line 177: config_file = optarg;

    this is also removing two cmdline options, is that intended? it is not mentioned in the commit log, seems better as a separate patch

To view, visit change 30950. To unsubscribe, or for help writing mail filters, visit settings.