Attention is currently required from: Hoernchen. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30966 ) Change subject: ms: adjust float<->integral type conversion ...................................................................... Patch Set 1: (6 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-trx/+/30966/comment/d37b3ba1_81001b22 PS1, Line 11: split the two cases. can you pinpoint where did you "split the two cases"? I'm either not understand correctly or I didn't find this change. File Transceiver52M/Complex.h: https://gerrit.osmocom.org/c/osmo-trx/+/30966/comment/c3202848_24fe3a7d PS1, Line 32: typedef Real value_type; why this typedef? File Transceiver52M/ms/ms.h: https://gerrit.osmocom.org/c/osmo-trx/+/30966/comment/653c726a_8bc182da PS1, Line 58: namespace cvt_internal please put some new line spacing between blocks inside here, otherwise it's hard to read. https://gerrit.osmocom.org/c/osmo-trx/+/30966/comment/a6401505_ff75baec PS1, Line 66: template <typename DST_T, typename ST> I don't think I'm following here. Why changing code to have 2 functions wih 2 templates types, instead of 1 function with 3 template types like before? Looks like code dup imho? https://gerrit.osmocom.org/c/osmo-trx/+/30966/comment/1e04fc3f_9f47ef8c PS1, Line 72: template <typename ST> void convert_and_scale_i(float *dst, const float *src, unsigned int src_len, ST scale) you have the template in a new line in functions above, but here in the same one. File Transceiver52M/ms/ms_upper.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/30966/comment/17eab4b3_6f0072ab PS1, Line 465: fesetround(FE_TOWARDZERO); can you explain why are you dropping this? -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30966 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I93f077f967daf2ed382d12cc20a54846b3688634 Gerrit-Change-Number: 30966 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen &lt;ewild(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: Hoernchen &lt;ewild(a)sysmocom.de&gt; Gerrit-Comment-Date: Fri, 13 Jan 2023 09:57:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment