Attention is currently required from: Hoernchen.

View Change

6 comments:

• Commit Message:

  • Patch Set #1, Line 11: split the two cases.

    can you pinpoint where did you "split the two cases"? I'm either not understand correctly or I didn't find this change.

• File Transceiver52M/Complex.h:

  • Patch Set #1, Line 32: typedef Real value_type;

    why this typedef?

• File Transceiver52M/ms/ms.h:

  • Patch Set #1, Line 58: namespace cvt_internal

    please put some new line spacing between blocks inside here, otherwise it's hard to read.

  • Patch Set #1, Line 66: template <typename DST_T, typename ST>

    I don't think I'm following here. Why changing code to have 2 functions wih 2 templates types, instead of 1 function with 3 template types like before? Looks like code dup imho?

  • Patch Set #1, Line 72: template <typename ST> void convert_and_scale_i(float *dst, const float *src, unsigned int src_len, ST scale)

    you have the template in a new line in functions above, but here in the same one.

• File Transceiver52M/ms/ms_upper.cpp:

  • Patch Set #1, Line 465: fesetround(FE_TOWARDZERO);

    can you explain why are you dropping this?

To view, visit change 30966. To unsubscribe, or for help writing mail filters, visit settings.