Attention is currently required from: laforge.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-sccp/+/34089 )
Change subject: ss7: Use libosmo-netif's osmo_stream_{cli,srv}_recv() APIs
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
the patch you're referring-to has not yet been
merged
ACk, we have to wait until it is merged.
Also, at the very least I would expect a TODO-RELEASE
update
It is there, you may have overlooked it 😊
To me, this kind of change *might* even rectify
bumping the libversion of libosmo-netif
The related change of libosmo-netif osmo_stream_cli now providing the SCTP_NOTIFICATIONS
like osmo_srv already does is backward compatible (old users don't need to be
rebuilt), because the SCTP_NTOIFICATIONS flagd are only provided upon return code -EAGAIN
or 0, so it shouldn't make major problems on apps.
Once this libosmo-sccp is released, it will depend on package libosmo-netif > 1.3.0
which will have such feature, so the problem is really during master which will be
released over next weeks. And whoever uses master mixed with "latest" should
know what he's doing.
So I don't think it's strictly needed to bump libversion on libosmo-netif since
users don't require rebuild (no ABI breakage), and libosmo-sccp configure.ac
dependencies should be enough in principle to avoid using older libosmo-netif.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-sccp/+/34089
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: If3d78b636e8e224aa9c8597d0b242e29d3e3c84e
Gerrit-Change-Number: 34089
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Wed, 09 Aug 2023 16:00:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment