Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30266 ) Change subject: paging: Store list of gsm_paging_request in bsc_subscr ...................................................................... Patch Set 3: Code-Review+1 (3 comments) File include/osmocom/bsc/bsc_subscriber.h: https://gerrit.osmocom.org/c/osmo-bsc/+/30266/comment/3175c358_9ed2c424 PS2, Line 57: gsm_paging_request Fine with me. File src/osmo-bsc/bsc_subscriber.c: https://gerrit.osmocom.org/c/osmo-bsc/+/30266/comment/a88f956c_7ac7ba04 PS3, Line 270: it could be freed during put(): I just took a look at the implementation of _osmo_use_count_get_put(), and... you're right. The refcounting API involves quite a lot of operations, so it's better be avoided here then. File src/osmo-bsc/paging.c: https://gerrit.osmocom.org/c/osmo-bsc/+/30266/comment/b9b4c65a_735ee29f PS3, Line 533: it could be freed during put(): Cleaner, but worse in terms of performance (unfortunately) :/ -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30266 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I831d0fe01d7812c34500362b90f47cd65645b666 Gerrit-Change-Number: 30266 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 22 Nov 2022 19:01:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment