Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30266 )

Change subject: paging: Store list of gsm_paging_request in bsc_subscr ......................................................................

Patch Set 3: Code-Review+1

(3 comments)

File include/osmocom/bsc/bsc_subscriber.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/30266/comment/3175c358_9ed2c424 PS2, Line 57: gsm_paging_request

In general yes, but for this one I preferred keeping it here with the subset of functions specifical […]

Fine with me.

File src/osmo-bsc/bsc_subscriber.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/30266/comment/a88f956c_7ac7ba04 PS3, Line 270: it could be freed during put():

I don't see the point in doing that here, that adds extra get/put which also triggers allocations, l […]

I just took a look at the implementation of _osmo_use_count_get_put(), and... you're right. The refcounting API involves quite a lot of operations, so it's better be avoided here then.

File src/osmo-bsc/paging.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/30266/comment/b9b4c65a_735ee29f PS3, Line 533: it could be freed during put():

Same here, doing get(__func__) .. put(__func__) would be cleaner.

Cleaner, but worse in terms of performance (unfortunately) :/