Attention is currently required from: pespin.

Patch set 3:Code-Review +1

View Change

3 comments:

• File include/osmocom/bsc/bsc_subscriber.h:

  • Patch Set #2, Line 57: gsm_paging_request

    In general yes, but for this one I preferred keeping it here with the subset of functions specifical […]

    Fine with me.

• File src/osmo-bsc/bsc_subscriber.c:

  • Patch Set #3, Line 270: it could be freed during put():

    I don't see the point in doing that here, that adds extra get/put which also triggers allocations, l […]

    I just took a look at the implementation of _osmo_use_count_get_put(), and... you're right. The refcounting API involves quite a lot of operations, so it's better be avoided here then.

• File src/osmo-bsc/paging.c:

  • Patch Set #3, Line 533: it could be freed during put():

    Same here, doing get(__func__) .. put(__func__) would be cleaner.

    Cleaner, but worse in terms of performance (unfortunately) :/

To view, visit change 30266. To unsubscribe, or for help writing mail filters, visit settings.